[SDK] Fix: ConnectEmbed SIWE Revalidation #5080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 67a363f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
size-limit report 📦
|
jnsdls
reviewed
Oct 18, 2024
|
|
||
| const queryClient = useQueryClient(); | ||
|
|
||
| // We need to reset the react query cache on mount for components like ConnectEmbed that are unmount and remount depending on the auth / connection state |
Member
There was a problem hiding this comment.
I would expect useQuery to already refetch on mount? That is the standard behavior.
gregfromstl
force-pushed
the
fix/siwe-auth-revalidation
branch
from
92716c2 to
a28ccb2
Compare
jnsdls
approved these changes
Oct 18, 2024
gregfromstl
force-pushed
the
fix/siwe-auth-revalidation
branch
from
a28ccb2 to
a192d30
Compare
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5080 +/- ##
==========================================
- Coverage 45.29% 45.29% -0.01%
==========================================
Files 1059 1059
Lines 54728 54729 +1
Branches 3954 3957 +3
==========================================
Hits 24791 24791
- Misses 29246 29247 +1
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing revalidation issues related to `siwe` authentication in the `ConnectEmbed` component by updating mutation keys to include the `activeAccount` address.
### Detailed summary
- Updated `mutationKey` for the `login` mutation to include `activeAccount?.address`.
- Updated `mutationKey` for the `logout` mutation to include `activeAccount?.address`.
- Added `gcTime`, `placeholderData`, and `refetchOnWindowFocus` options in the hook configuration.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
fix/siwe-auth-revalidation
branch
from
a192d30 to
67a363f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing revalidation issues with
siweauthentication in theConnectEmbedcomponent by updating the mutation keys to include theactiveAccountaddress.Detailed summary
mutationKeyforloginto includeactiveAccount?.address.mutationKeyforlogoutto includeactiveAccount?.address.gcTime,placeholderData, andrefetchOnWindowFocusoptions in the hook configuration.